Today i installed the new version 2.1.2 without modification and on every offer it says Whooops, There Was Some Error. Please Try To Add Offer Later.
I had this before but cannot remember how I've solved it.....

User receives mail there is a new offer and it shows also in instant messenger ..... Only problem is the error instead off green light saying offer is sent.

@mwindey
Check error logs as well as browser log (console)

@MB Themes

First i will check this out....

Line 323 from instant messenger / functions says
  $extension = strtolower(pathinfo(@$file['name'], PATHINFO_EXTENSION));

Debug log when trying to add bid gives error:


[07-Sep-2022 13:56:23 Europe/Brussels] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /home/u44173p136925/domains/wirly.be/public_html/oc-content/plugins/instant_messenger/functions.php:323
Stack trace:
#0 /home/u44173p136925/domains/wirly.be/public_html/oc-content/plugins/make_offer/index.php(176): im_insert_message()
#1 /home/u44173p136925/domains/wirly.be/public_html/oc-includes/osclass/classes/Plugins.php(42): mo_new_offer_manage()
#2 /home/u44173p136925/domains/wirly.be/public_html/oc-includes/osclass/helpers/hPlugins.php(34): Plugins::runHook()
#3 /home/u44173p136925/domains/wirly.be/public_html/oc-includes/osclass/controller/ajax.php(314): osc_run_hook()
#4 /home/u44173p136925/domains/wirly.be/public_html/index.php(146): CWebAjax->doModel()
#5 {main}
  thrown in /home/u44173p136925/domains/wirly.be/public_html/oc-content/plugins/instant_messenger/functions.php on line 323


When instant messenger is disabled in make offer it works but that is not how it should be.....

Hate the PHP

above that line try to add:
  if(!is_array($file) || empty($file)) {
    return '';
  }

@MB Themes

PHP sucks 
Cleared browser and all caches i have. Inserted code and still same error....

Urgent time to learn ASP and leave this f**x***   

@MB Themes

SOLVED  with a little help from stackoverflow....
Because of the use from PHP 8 there where some changes again ( it's hard to keep up these days)

Anyway the full code from that part in functions.php from instant messenger that is working correct is:

  // MANAGE FILE UPLOAD
  $allowed_extensions = (im_param('att_extension') <> '' ? im_param('att_extension') : 'jpg, jpeg, gif, png' );
  $allowed_extensions = array_map('strtolower', array_filter( array_map('trim', explode( ',', $allowed_extensions ) ) ) );
  if (!empty($file) || empty($file)) {
    return '';
  }
  $extension = strtolower(pathinfo(@$file['name'], PATHINFO_EXTENSION));

Thanks for the help 

@mwindey
Here, we could also add after function:
  if(!is_array($file)) {
    $file = array();
  }

@MB Themes

You mean instead of
  if (!empty($file) || empty($file)) {
    return '';
  }
OR   

(confused)

They should not be in conflict.

@MB Themes,

My solution wasn't the right solution.... However it worked but NO mails were send to notice user he/she received an offer or message anymore.

The solution you gave is working perfectly now. Mails are send to user and make offer does not give any error anymore.

Code that works is in lines

// MANAGE MESSAGE INSERT INTO DATABASE
function im_insert_message($thread_id, $message, $type, $file, $notify = true ) {
  if(!is_array($file)) {
    $file = array();
  }
  if(im_param('only_logged') == 1 && !osc_is_web_user_logged_in()) {
    return false;
  }
 
  $thread = ModelIM::newInstance()->getThreadById( $thread_id );
  $item = Item::newInstance()->findByPrimaryKey( $thread['fk_i_item_id'] );

Again you have been a great help solving this.... Thanks 

@MB Themes,

We still have some work in progress....
Since changing functions.php in instant messenger mails gets send to seller but instead of mo_notify_seller -  email_item_inquiry gets send which is the wrong email...

It is not a big problem but when a buyer is bidding without sending text the seller gets informed there is a new message waiting but not a message someone has placed a bid on the item.

Do you think we can make the file so that it recognizes if it is an offer or just a message someone is sending

 

It should be just light integration to IM that isert message with not much details.
I actually never used that