Error in semantic url in premium display
I am creating a premium display with the following code.

   <?php osc_get_premiums(4); ?>
<?php if (osc_count_premiums() > 0) { ?>

<?php  while (osc_has_premiums()) { ?>

 <a href="<?php echo osc_premium_url(); ?>"></a>
 <?php } ?>
  <?php } ?>

To Reproduce

Anomaly only plays on premium urls
domain/category/subcategory/{ITEM_CITY}/ads-example_i1

Expected behavior
non-premium url expected behavior

domain/category/subcategory/city/ads-example_i1

My permalink settings
{CATEGORIES}/{ITEM_CITY}/{ITEM_TITLE}_i{ITEM_ID}

Is there something wrong in my approach or is it an osclass bug

Ok so for premium items {ITEM_CITY} is not properly translated into city value. Right?

Exactly, if you need more information about my development scenario.

will try to check soon

I am checking this in the file /oc-includes/osclass/helpers/hDifines.php

function osc_premium_url($locale = '') {
  if ( osc_rewrite_enabled() ) {
    $sanitized_categories = array();
    $cat = Category::newInstance()->hierarchy(osc_premium_category_id());
   
    for ($i = count( $cat); $i > 0; $i--) {
      $sanitized_categories[] = $cat[$i - 1]['s_slug'];
    }
   
    $url = str_replace(
      array('{ITEM_ID}', '{CATEGORIES}'),
      array(osc_premium_id(), implode( '/' , $sanitized_categories)),
      str_replace( '{ITEM_TITLE}', osc_sanitizeString( str_replace( ',', '-', osc_premium_title())), osc_get_preference( 'rewrite_item_url'))
    );

    if($locale!='') {
      $path = osc_base_url() . $locale . '/' . $url;
    } else {
      $path = osc_base_url() . $url;
    }
  } else {
    $path = osc_item_url_ns(osc_premium_id(), $locale);
  }
  return $path;
}

Not quite sure if it is defined here, but you can try to add before line     if($locale!='') {
following:

if(osc_premium_city() <> '') {
  $url = str_replace(('{ITEM_CITY}', osc_premium_city(), $url);
} else {
  $url = str_replace(('/{ITEM_CITY}/', '/', $url);
}

I was trying a similar approach to yours, to rewrite the url
obtaining an optimal result, but not appropriate in the cases of users who want their urls to have a good SEO, due to the use of upper and lower case in the rewriting of the url.

#Parenthesis correction
#functional to test it

 if(osc_premium_city() <> '') {
  $url = str_replace('{ITEM_CITY}', osc_premium_city(), $url);
} else {
  $url = str_replace('/{ITEM_CITY}/', '/', $url);
}

So does it fix the issue or not?
I am not sure if letter size has any effect on seo.

It works well, you just have to test it more to have greater security.
That's what I'll be doing the next few days testing.

I'll tell you about any anomaly you may have.
grateful for your provision. 

Yes, great, I will review code also for other keywords

@Maxdual
try to replace whole function with just one line:
return osc_item_url_from_item(osc_premium(), $locale);
It should fix issue completely.

 
I am testing in my environment return osc_item_url_from_item(osc_premium(), $locale); and the problem is completely solved.
obtaining a url without capital letters, commas or accents, very optimal for users looking for a good SEO with their urls.
Excellent the last solution is more complete and better performance is achieved

 

Yes great thanks for confirmation