Osclass Support Forums
General osclass questions => Report bug => Topic started by: Wiz on February 14, 2023, 12:11:06 AM
-
Hello,
Searching cities, regions or countries in languages other than English (when switched to a language other than English) yields no results on the main page under 8.1.1 - works fine on the search page. Searching for items / categories etc. works fine in any language. It's just locations that aren't searchable anymore.
Strangely enough, searching in English while viewing other languages (non-English) outputs results in the selected language. I believe this is a core issue, perhaps with locales and/or the new rewrite / redirect rules in index / languages / rewrite / helpers / search.
Tested on osclass 8.1.1 (upgraded from 8.0.2) with latest epsilon.
Thanks
-
@Wiz
Could not reproduce.
Can you provide details in wich box it does not work, link it used to get results, and query if you have it?
-
@MB The search box on the homepage - see attached screenshots.
When دبي is typed under the Arabic version of the test site, no results are returned (دبي in Arabic was added as a native word for the region/city).
When Dubai is typed in English under the Arabic version, Arabic location results are returned.
Searching locations using English on English version of the site works fine.
Forgot to add: this was working perfectly fine under 8.0.2 and I'll share the queries soon.
-
@Wiz
In theme model, try to change (3 times, for cities it starts with c.s_name...):
$this->dao->where('s_name like "%' . osc_esc_html($pattern) . '%"');
into:
if(osc_get_current_user_locations_native() == 1) {
$this->dao->where(sprintf('(s_name like "%%%s%%" OR s_name_native like "%%%s%%")', osc_esc_html($pattern), osc_esc_html($pattern)));
} else {
$this->dao->where(sprintf('s_name like "%%%s%%"', osc_esc_html($pattern)));
}
-
@Wiz
In theme model, try to change (3 times, for cities it starts with c.s_name...):
$this->dao->where('s_name like "%' . osc_esc_html($pattern) . '%"');
into:
if(osc_get_current_user_locations_native() == 1) {
$this->dao->where(sprintf('(s_name like "%%%s%%" OR s_name_native like "%%%s%%")', osc_esc_html($pattern), osc_esc_html($pattern)));
} else {
$this->dao->where(sprintf('s_name like "%%%s%%"', osc_esc_html($pattern)));
}
Worked perfectly for regions and countries, thank you ;) For cities, I had to replace s_name with c.s_name in the code you provided as such:
if(osc_get_current_user_locations_native() == 1) {
$this->dao->where(sprintf('(c.s_name like "%%%s%%" OR c.s_name_native like "%%%s%%")', osc_esc_html($pattern), osc_esc_html($pattern)));
} else {
$this->dao->where(sprintf('c.s_name like "%%%s%%"', osc_esc_html($pattern)));
}
I also noticed another bug while testing the above fix (probably old) ... "Your recent search" and "Other People Searched" is only displaying in English but not for RTL languages searches. "ٌYour recent search" loads in the search bar fine when not entering anything in the search bar (clicking inside) on RTL but as soon as you enter a pattern, "Your recent search" is no longer returned even though the the pattern was searched before. "Other people searched" didn't load once under RTL.
-
Well if you search "car", it will be "car" in all languages
-
That's true but that's not what the bug is about.
When searching in epsilon on the homepage, you can see your latest searches and what other people searched if you enter something you searched for or matches what someone else searched for before in English under English or other languages. That's working fine.
In RTL, the 'what other people searched for' is only shown if you enter the previously searched for term in English... It will not show up for non-English RTL keywords searched for previously.
Makes sense? I can take new screenshots if you like.
-
Checked on demo and latest searches are identical in all languages.
-
You probably searched for something other than a location - try searching for a location in different languages using native names and you'll see the bug.
-
This can be related to transfering special characters.
Try to check in network tab what term was used here