Support Forums - Classified Ads Script Osclass

General osclass questions => Report bug => Topic started by: Дима Пупкин on December 12, 2023, 10:41:39 PM

Title: Canonical tag
Post by: Дима Пупкин on December 12, 2023, 10:41:39 PM

Hello, I apologize for the fact that I am looking in the wrong category. I need your help. when I enable the "Canonical tag Always Generate Canonical URL tag. It is generated on every page (not just search)" function in the admin panel. the code displays http:// but I need https:// how to fix this

Title: Re: Canonical tag
Post by: MB Themes on December 13, 2023, 10:28:31 AM

Why you think it should work just on search page?

here is code used to get URL:

Code: [Select]

function osc_get_current_url() {
  if(isset($_SERVER['HTTP_HOST']) && isset($_SERVER['REQUEST_URI'])) {
    return (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] === 'on' ? "https" : "http") . '://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'];
  }

  return false;
}
I would say if you get http, then your server variable has https off.

Title: Re: Canonical tag
Post by: Дима Пупкин on December 13, 2023, 11:31:57 AM

Sorry, I worded the question incorrectly. when I enable the "Canonical tag" feature in the admin panel. The conanical link is generated by the http:// protocol. although I have an SSL certificate configured and the entire site runs on https://, only the conanical link is generated by http://. Tell me what needs to be fixed so that the "Canonical tag" generates the link https://

Title: Re: Canonical tag
Post by: MB Themes on December 13, 2023, 01:47:26 PM

Means $_SERVER['HTTPS'] <> 'on'
Check with your hosting

Title: Re: Canonical tag
Post by: MB Themes on December 13, 2023, 01:52:36 PM

You may also try to udpate that function (in oc-includes/osclas/utils.php) into:

Code: [Select]

function osc_get_current_url() {
  if(isset($_SERVER['HTTP_HOST']) && isset($_SERVER['REQUEST_URI'])) {
    return (osc_is_ssl() ? "https://" : "http://") . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'];
  }

  return false;
}

Title: Re: Canonical tag
Post by: Дима Пупкин on December 13, 2023, 10:22:55 PM

Thank you for your help and work, you are the best. everything works as it should!