Support Forums - Classified Ads Script Osclass

General osclass questions => Report bug => Topic started by: Дима Пупкин on December 29, 2023, 05:46:31 PM

Title: Help me solve the problem, I have two canonical tags being generated.
Post by: Дима Пупкин on December 29, 2023, 05:46:31 PM

Help me solve the problem, I have two canonical tags being generated.
/dom-i-sad
/dom-i-sad/
How can I make sure that on a page with slashes "/" the conanical address is without the slash /dom-i-sad

Title: Re: Help me solve the problem, I have two canonical tags being generated.
Post by: MB Themes on December 30, 2023, 09:08:11 PM

Well you shoukd find out how it is generated and where.
Then you can correct code.

Title: Re: Help me solve the problem, I have two canonical tags being generated.
Post by: MB Themes on December 30, 2023, 09:08:36 PM

Or update canonical url function to always remove last slash.

Title: Re: Help me solve the problem, I have two canonical tags being generated.
Post by: Дима Пупкин on December 31, 2023, 09:46:16 PM

Quote from: MB Themes on December 30, 2023, 09:08:36 PM

Or update canonical url function to always remove last slash.

Please tell me how to do this?

Title: Re: Help me solve the problem, I have two canonical tags being generated.
Post by: MB Themes on January 04, 2024, 09:48:14 PM

Add this to your functions:

Code: [Select]

// Enhance canonical URLs
function osc_enhance_canonical_url($url) {
  if($url != osc_base_url() && $url != osc_base_url(false, true) && osc_rewrite_enabled()) {
    if(substr($url, -1) == '/') {
      $url = substr($url, 0, strlen($url)-1);
    }
  }
 
  return $url; 
}

osc_add_filter('canonical_url', 'osc_enhance_canonical_url');
osc_add_filter('canonical_url_osc', 'osc_enhance_canonical_url');
osc_add_filter('canonical_url_search', 'osc_enhance_canonical_url');
osc_add_filter('canonical_url_public_profile', 'osc_enhance_canonical_url');

Title: Re: Help me solve the problem, I have two canonical tags being generated.
Post by: Дима Пупкин on January 06, 2024, 03:46:54 PM

Quote from: MB Themes on January 04, 2024, 09:48:14 PM

Add this to your functions:

Code: [Select]

// Enhance canonical URLs
function osc_enhance_canonical_url($url) {
  if($url != osc_base_url() && $url != osc_base_url(false, true) && osc_rewrite_enabled()) {
    if(substr($url, -1) == '/') {
      $url = substr($url, 0, strlen($url)-1);
    }
  }
 
  return $url; 
}

osc_add_filter('canonical_url', 'osc_enhance_canonical_url');
osc_add_filter('canonical_url_osc', 'osc_enhance_canonical_url');
osc_add_filter('canonical_url_search', 'osc_enhance_canonical_url');
osc_add_filter('canonical_url_public_profile', 'osc_enhance_canonical_url');

unfortunately this method did not help me, I added this code to functions.php but still two conanic tags are generated with and without "/"

Title: Re: Help me solve the problem, I have two canonical tags being generated.
Post by: Дима Пупкин on January 06, 2024, 05:57:33 PM

Please tell me, using GPT chat I was able to solve the problem, will this be the right solution?

i changed this code

Code: [Select]

// Generate canonical URL on all pages
function osc_generate_canonical() {
  if(osc_always_generate_canonical_enabled()) {
    View::newInstance()->_exportVariableToView('canonical', osc_get_current_url());
  }
}

osc_add_hook('init', 'osc_generate_canonical', 1);
on which the GPT chat was created

Code: [Select]

// Generate canonical URL on all pages
function osc_generate_canonical() {
  if (osc_always_generate_canonical_enabled()) {
    $currentUrl = osc_get_current_url();

    // Remove trailing slash if it exists
    $currentUrl = rtrim($currentUrl, '/');

    View::newInstance()->_exportVariableToView('canonical', $currentUrl);
  }
}

osc_add_hook('init', 'osc_generate_canonical', 1);

Title: Re: Help me solve the problem, I have two canonical tags being generated.
Post by: MB Themes on January 08, 2024, 01:14:35 PM

Looks to have same effect  ;)