This topic contains a post which is marked as Best Answer. Press here if you would like to see it.
*

piter

  • ****
  • 104 posts
GDPR plugin supplied with Alpha breaks the design
« on: February 18, 2019, 04:35:38 PM »
GDPR plugin supplied with Alpha theme has some css issue and breaks the design.

On Log In form:
- whenever CSS style is applied to checkboxes or not on plugin settings page, it does not have any effect, the checkbox looks the same
- Remember Me checkbox/link doesnt work, checkbox cant be ticked nor unticked

On Sign In form:
- when css style is applied, checkboxes breaks the design (see attachment)
- checkboxes itself doesnt work, cant be ticked on
- when clicking on the links for TOC and PP A NEW open gets open with those pages (user should be keept on one window, no point for opening TOC in a new window)
- after link has been clicked and a new window open, tickboxes gets active (ticked on), to deactivate checkboxes those link needs be clicked again... It can't be that way. Checkboxes are independent elements and should be active/not active by clicking directly on them.

*

MB Themes

Re: GDPR plugin supplied with Alpha breaks the design
« Reply #1 on: February 18, 2019, 08:45:11 PM »
@piter

On Log In form:
- whenever CSS style is applied to checkboxes or not on plugin settings page, it does not have any effect, the checkbox looks the same
theme should care about styling, I was not able to reproduce issue.
- Remember Me checkbox/link doesnt work, checkbox cant be ticked nor unticked
will be fixed in next update

On Sign In form:
- when clicking on the links for TOC and PP A NEW open gets open with those pages (user should be keept on one window, no point for opening TOC in a new window)
if it would not be like that, you would complain why it does not open in new window. Reason is simple, link is at bottom of page, this means if I click to read content there (in same window), I would got wiped out whole form and would need to fill it again. 95% chance I would not do it again
- after link has been clicked and a new window open, tickboxes gets active (ticked on), to deactivate checkboxes those link needs be clicked again... It can't be that way. Checkboxes are independent elements and should be active/not active by clicking directly on them.
as link is inside label, it triggers click, I will check wheter is possible to disable click event
« Last Edit: February 18, 2019, 09:31:50 PM by MB Themes »
  To get fast support, we need following details: Detail description, URL to reproduce problem, Screenshots

*

piter

  • ****
  • 104 posts
Re: GDPR plugin supplied with Alpha breaks the design
« Reply #2 on: February 18, 2019, 11:48:38 PM »
if it would not be like that, you would complain why it does not open in new window. Reason is simple, link is at bottom of page, this means if I click to read content there (in same window), I would got wiped out whole form and would need to fill it again. 95% chance I would not do it again
Filling in reg form again shouldn't be a problem as it is simple 4 fields. But there is always other poin of view so understand what you say.

as link is inside label, it triggers click, I will check wheter is possible to disable click event
I've never seen checkboxes work the way as on Alpha, it is strange design. But all I say is just me. You are main developer so its up to you to decide how your app works. Others can customise if they dont like it  :D



« Last Edit: February 18, 2019, 11:50:15 PM by piter »

Marked as best answer by frosticek on February 19, 2019, 08:09:36 PM
*

MB Themes

Re: GDPR plugin supplied with Alpha breaks the design
« Reply #3 on: February 19, 2019, 08:38:03 AM »
@piter
Please update to v1.0.5 that contains several fixes
  To get fast support, we need following details: Detail description, URL to reproduce problem, Screenshots

*

piter

  • ****
  • 104 posts
Re: GDPR plugin supplied with Alpha breaks the design
« Reply #4 on: February 19, 2019, 07:34:50 PM »
yes.. now is how checkboxes should work :-),

And you are right in this case, opening TAC and PP in a new window will save filling in forms from the scratch. I didnt realised that those checkboxes are included not only on register page but on publish a new item page too. And those could be long forms (i.e. for the cars with a lot of custom fields added). Good work !
« Last Edit: February 19, 2019, 10:13:46 PM by piter »

*

MB Themes

Re: GDPR plugin supplied with Alpha breaks the design
« Reply #5 on: February 19, 2019, 08:09:27 PM »
Welcome  ;)
  To get fast support, we need following details: Detail description, URL to reproduce problem, Screenshots