*

Wiz

  • ****
  • 138 posts
Several minor requests for the upcoming 8.1.2 release
« on: February 14, 2023, 09:38:55 AM »
Hello,

Can we kindly have PHPMailer updated to the latest 6.7.1 release (tested locally, simple drag & drop, backward compatible to php 5.5)?

And by looking at https://cyan4973.github.io/xxHash/, perhaps we can also upgrade the hash from md5 to xxh3 for php ≥8.1 installs (also tested locally, working nicely).

Tinymce - is on versions 6, doesn't use "mode" option anymore, just selector and some plugins have been merged into the main release.


Font awesome - is also at version 6 (6.3 to be exact) has been out for a while and is backward compatible with fa/fas/far so it can be upgraded across the board (including free/paid plugins). You can use latest branch link to avoid having to manually update links to current versions in the future https://cdn.jsdelivr.net/npm/@fortawesome/fontawesome-free/css/all.min.css

Nice to have for future minor releases - Adding osc_is_rtl function to frontend free / paid plugins with user rtl styles which can be automated with a converter plugin or done online.

Thanks!

*

MB Themes

Re: Several minor requests for the upcoming 8.1.2 release
« Reply #1 on: February 14, 2023, 12:00:51 PM »
@Wiz
PHP mailer was updated in 8.1.0 somewhere in December I think. Will check when 8.1.2 will be ready.
For font awesome 6, not planned. Getting lost with these updates, compatibility never works well to v5/v4, they are changing everything regularly.
For tinymce 6, not planned. Do not see much benefits in v6 yet, looks more-less exactly same as v5.
  To get fast support, we need following details: Detail description, URL to reproduce problem, Screenshots

*

cartagena68

  • ***
  • 71 posts
Re: Several minor requests for the upcoming 8.1.2 release
« Reply #2 on: February 14, 2023, 02:49:32 PM »
@MB Themes

Sorry if I use this post, but is a minor request too.
It is possible to add a delete button beside the download button in Tools->Debug/Error log so that is possible to delete the file without using FTP or Server control panel?
Thank you

*

MB Themes

Re: Several minor requests for the upcoming 8.1.2 release
« Reply #3 on: February 14, 2023, 03:11:52 PM »
@cartagena68
Yes that is possible.
  To get fast support, we need following details: Detail description, URL to reproduce problem, Screenshots

*

cartagena68

  • ***
  • 71 posts
Re: Several minor requests for the upcoming 8.1.2 release
« Reply #4 on: February 14, 2023, 03:15:47 PM »
@cartagena68
Yes that is possible.

 :) Thank you

*

MB Themes

Re: Several minor requests for the upcoming 8.1.2 release
« Reply #5 on: February 14, 2023, 06:37:29 PM »
@Wiz
Quote
Adding osc_is_rtl function to frontend free / paid plugins with user rtl styles which can be automated with a converter plugin or done online.

Can you be more specific about your idea and conversion?
Right now all rtl related styling is hold by theme.
Our idea was to update html attribute dir to ltr/rtl and let rtl styles be applicable by this attribute, so no extra stylesheet is required.
  To get fast support, we need following details: Detail description, URL to reproduce problem, Screenshots

*

Wiz

  • ****
  • 138 posts
Re: Several minor requests for the upcoming 8.1.2 release
« Reply #6 on: February 14, 2023, 07:28:03 PM »
@Wiz
Quote
Adding osc_is_rtl function to frontend free / paid plugins with user rtl styles which can be automated with a converter plugin or done online.

Can you be more specific about your idea and conversion?
Right now all rtl related styling is hold by theme.
Our idea was to update html attribute dir to ltr/rtl and let rtl styles be applicable by this attribute, so no extra stylesheet is required.

It's true, theme has RTL styling but only for theme elements and not for plugins ie. pay, blog, invoice, business profile and so many more. They're all LTR even with RTL direction set in head and/or plugin language has been translated. No RTL alignment whatsoever and numbers are reversed!

Consistency is very important.

The idea I'm proposing is expanding the use of osc_is_rtl (new function) or use current osc_locale_is_rtl function across all plugins with frontend/facing user interaction (not all plugins require RTL styling) ie:

Code: [Select]
if(osc_locale_is_rtl()) {
  osc_enqueue_style('bpr-user-rtl-style', osc_base_url() . 'oc-content/plugins/business_profile/css/user-rtl.css?v=' . date('YmdHis'));
}

And use something like https://github.com/moodlehq/rtlcss-php or a better backend converter or framework that converts on RTL language activation with maybe an option to manually manage CSS styling via the plugin itself (via gui).

I don't recommend adding plugin RTL styling to the theme's RTL styling as it would grow in size, slow things down and users may have  1, 2, all plugins or none at all.

Forgot to add - best part, you'll be saving yourself dev time and time is $$$$
« Last Edit: February 14, 2023, 07:32:55 PM by Wiz »

*

MB Themes

Re: Several minor requests for the upcoming 8.1.2 release
« Reply #7 on: February 14, 2023, 08:00:32 PM »
Not sure about that library, it woukd need a lot of testing to see if it works
  To get fast support, we need following details: Detail description, URL to reproduce problem, Screenshots

*

Wiz

  • ****
  • 138 posts
Re: Several minor requests for the upcoming 8.1.2 release
« Reply #8 on: February 14, 2023, 08:32:04 PM »
That's how I'm handling RTL for plugins but I'm doing the conversion online using https://rtlcss.com/playground/index.html which is available on github at https://github.com/MohammadYounes/rtlcss

There are other converters/frameworks for this purpose.

I'm sure you know this, osclass core was coded over 10 or 11 years ago when barely any frameworks were available, everything was coded from scratch or based on wordpress... now there are frameworks for everything, including the most challenging and troubling issues with osclass - routing (without 302 redirections) and seo friendly urls as SEO was not a specialization of any of the main developers (they even admitted it on github).

We're getting there, bit by bit.

Thank you for your efforts!
« Last Edit: February 14, 2023, 08:36:50 PM by Wiz »

*

Wiz

  • ****
  • 138 posts
Re: Several minor requests for the upcoming 8.1.2 release
« Reply #9 on: March 01, 2023, 02:46:30 AM »
@MB

Thanks so much for baking RTL support in the recently updated plugins. I like your simple and straightforward css way!

Look forward to the rest, especially Osclass Pay as it has many elements.

Cheers
Wiz

*

MB Themes

Re: Several minor requests for the upcoming 8.1.2 release
« Reply #10 on: March 01, 2023, 06:43:11 PM »
@Wiz
Osclass pay is done already and updated together with invoice plugin.
There is little down size of having little of extra lines, but its not that terrible  :)
  To get fast support, we need following details: Detail description, URL to reproduce problem, Screenshots

*

Wiz

  • ****
  • 138 posts
Re: Several minor requests for the upcoming 8.1.2 release
« Reply #11 on: March 01, 2023, 10:34:14 PM »
@MB

That was quick! 8)

True, a couple of extra lines of css won't hurt especially since loading times are already sub 1 ~ 1.5s and they're only enqueued when needed so there's that as well.

There's still a few more plugins that require RTL support ie. make offer, booking etc., are you working on those too?
You got those done too  :)

Also, and while we're on the subject of css and presentation, it would be great if you'd consider merging the comments (received and made) into a similar unified layout as make offer (2 tabs with notification alerts for comments received / comments made) so there's less navigation links and pages to present / load.

I think it would aesthetically look better from a UX/navigation perspective.

Thanks again!

« Last Edit: March 02, 2023, 05:05:04 PM by Wiz »

*

Wiz

  • ****
  • 138 posts
Re: Several minor requests for the upcoming 8.1.2 release
« Reply #12 on: March 21, 2023, 03:25:19 PM »
@MB

I certainly hope 8.1.2 is coming soon with language url out of beta.. really need this feature with working plugins.

Please let me know If there's anything I could assist with, ie. testing etc. as I have most of the plugins.

Thank you!

*

MB Themes

Re: Several minor requests for the upcoming 8.1.2 release
« Reply #13 on: March 22, 2023, 05:15:27 PM »
@Wiz
In your config.php set:
Code: [Select]
define('BETA_TEST', true);
Then look for new updates.
You should do this just on TEST site, not production.
You will be able to download and test 8.1.2 ;)
  To get fast support, we need following details: Detail description, URL to reproduce problem, Screenshots

*

Wiz

  • ****
  • 138 posts
Re: Several minor requests for the upcoming 8.1.2 release
« Reply #14 on: March 22, 2023, 08:15:49 PM »
@Wiz
In your config.php set:
Code: [Select]
define('BETA_TEST', true);
Then look for new updates.
You should do this just on TEST site, not production.
You will be able to download and test 8.1.2 ;)

Niiiice! I'll get cracking on it. What's your preferred reporting medium? email, chat, forum?

Thanks